Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6551 - assert statements for test test_header_validation #6552

Merged
merged 1 commit into from
Oct 18, 2023
Merged

#6551 - assert statements for test test_header_validation #6552

merged 1 commit into from
Oct 18, 2023

Conversation

swims-hjkl
Copy link
Contributor

added assert statements tests/test_requests/test_header_validation in regards to the issue #6551

sethmlarson
sethmlarson approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me?

nateprewitt
nateprewitt approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 😅 This is what should be there. Thanks @swims-hjkl!

@nateprewitt nateprewitt merged commit 839a8ed into psf:main Oct 18, 2023
7 of 28 checks passed
@nateprewitt nateprewitt mentioned this pull request Oct 18, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swims-hjkl @nateprewitt @sethmlarson