[Bug]: Collaborator private attributes were accessible from Aggregator steps #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at collaborator private variables are not accessible to aggregators
…s local_runtime._collaborators is no longer accessible. Updated Workflow Interface testcases and Tutorials with this change
- Aggregator private attributes are accessible only in Aggregator steps - Collaborator private attributes are accessible only in Collaborator steps
psfoley
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
Fix Summary:
Changes:
Framework Modules: collaborator is made a private attribute of LocalRuntime
openfl/experimental/runtime/local_runtime.py
New Testcase: Workflow interface test to validate this functionality
tests/github/experimental/testflow_privateattributes.py
Updates to existing Test cases: local_runtime._collaborators is modified to local_runtime.collaborator
tests/github/experimental/testflow_exclude.py
tests/github/experimental/testflow_include.py
tests/github/experimental/testflow_include_exclude.py
tests/github/experimental/testflow_internalloop.py
tests/github/experimental/testflow_reference.py
tests/github/experimental/testflow_reference_with_exclude.py
tests/github/experimental/testflow_reference_with_include.py
Updates to Tutorials: local_runtime._collaborators is modified to local_runtime.collaborator
openfl-tutorials/experimental/Global_DP/Workflow_Interface_Mnist_Implementation_1.py
openfl-tutorials/experimental/Global_DP/Workflow_Interface_Mnist_Implementation_2.py
openfl-tutorials/experimental/Privacy_Meter/cifar10_PM.py
openfl-tutorials/experimental/Vertical_FL/Workflow_Interface_VFL_Two_Party.ipynb
openfl-tutorials/experimental/Vertical_FL/Workflow_Interface_Vertical_FL.ipynb
openfl-tutorials/experimental/Workflow_Interface_101_MNIST.ipynb
openfl-tutorials/experimental/Workflow_Interface_102_Aggregator_Validation.ipynb
openfl-tutorials/experimental/Workflow_Interface_201_Exclusive_GPUs_with_Ray.ipynb
openfl-tutorials/experimental/Workflow_Interface_301_MNIST_Watermarking.ipynb