-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend returning info in the getValidators() API #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pshenmic
requested changes
Jun 22, 2024
pshenmic
requested changes
Jun 25, 2024
pshenmic
reviewed
Jun 25, 2024
pshenmic
requested changes
Jun 26, 2024
pshenmic
requested changes
Jun 26, 2024
pshenmic
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
To finish validators page (#152), we need to add few metadata fields in the response of the getValidators() query with such data:
Total proposed blocks count
Last proposed block height ( + timestamp)
Things Done
Now in response to
getValidators
andgetValidatorByProTxHash
query we get data of this format:To get the new fields it was necessary to realize one more database access, but already in the blocks table, then process the data and after that produce a response.
Tests have also been adjusted to work with the new data
README.md
was updated with information aboutgetValidators
andgetValidatorByProTxHash