-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP address / Port for Validator #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
owl352
force-pushed
the
feat/validators-info
branch
from
July 15, 2024 16:54
f48f55b
to
c6dee88
Compare
pshenmic
requested changes
Jul 15, 2024
pshenmic
requested changes
Jul 15, 2024
pshenmic
requested changes
Jul 16, 2024
pshenmic
requested changes
Jul 18, 2024
pshenmic
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Right now, we only have protx hash available from Tenderdash RPC, the host and port of the node is not implemented, so this info is only available in the Core chain.
Users should be able to see ip address and ports of the services running on this validat
Things done
DashCoreRPC
class was created (LikeTenderdashRPC
).Validator
class has been modified, and theValidatorsController
has also been modified.I also updated
README.md
and corrected it by adding the missing sectionsNow we get this response for the validators