-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle legacy masternodes in the protx info call #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pshenmic
requested changes
Aug 2, 2024
pshenmic
requested changes
Aug 2, 2024
pshenmic
approved these changes
Aug 2, 2024
pshenmic
changed the title
Validators fix
Handle legacy masternodes in the protx info call
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There was a problem with getting proTxInfo for some specific validator that has been removed from the network. For such masternodes, you need to provide a block hash to get a correct data.
An example of such validator:
1404DDD2C5433554EBECB2CB2C3A8581C10D950D9B0E3374117DC10BC1BF3265A16A
Things done
An implementation was added to the
getProTxInfo
call the handles "protxinfo not found" error and isses angetRawTransaction
method to get the hash of a block that we retry with to the getProTxInfo again.