Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy masternodes in the protx info call #208

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

owl352
Copy link
Collaborator

@owl352 owl352 commented Aug 1, 2024

Issue

There was a problem with getting proTxInfo for some specific validator that has been removed from the network. For such masternodes, you need to provide a block hash to get a correct data.

An example of such validator: 1404DDD2C5433554EBECB2CB2C3A8581C10D950D9B0E3374117DC10BC1BF3265A16A

Things done

An implementation was added to the getProTxInfo call the handles "protxinfo not found" error and isses an getRawTransaction method to get the hash of a block that we retry with to the getProTxInfo again.

@owl352 owl352 added the backend Related to backend (API) label Aug 1, 2024
@owl352 owl352 self-assigned this Aug 1, 2024
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-explorer-zham ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 5:20pm

packages/api/src/dashcoreRpc.js Show resolved Hide resolved
packages/api/src/dashcoreRpc.js Outdated Show resolved Hide resolved
@pshenmic pshenmic changed the title Validators fix Handle legacy masternodes in the protx info call Aug 2, 2024
@pshenmic pshenmic merged commit 680d0f3 into master Aug 2, 2024
8 checks passed
@owl352 owl352 deleted the feat/validators-fix branch November 23, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend (API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants