Any range statistics for graphs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pshenmic
requested changes
Oct 18, 2024
# Conflicts: # packages/api/src/controllers/ValidatorsController.js # packages/api/src/utils.js # packages/api/test/integration/validators.spec.js
pshenmic
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At this moment, we can get statistic only for
1h,24h,3d,1wtimespan's with fixed intervals (12 per timespan)Things done
At this PR, was implemented generator for intervals, whose steps we can easily customize
Also now we take as input not
timespan, butstart=andend=, which allows date in ISO format (2024-01-01T00:00:00Z)Also, integration tests for transaction statistics have been implemented and tests for validator statistics have been updated
We would also like to note that we can control the minimum number of steps for timespan. The current implementation does not allow us to set the maximum number of steps for a timespan, but it allows us to partially fix this by smooth transitions between steps. Current settings allow to get no more than 12 intervals (5 minutes in 1 hour min), and an infinite number of timespans when scheduling by years (max unit), but not less than 3