Withdrawals data from dapi #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
owl352
commented
Nov 18, 2024
owl352
commented
Nov 18, 2024
pshenmic
requested changes
Nov 18, 2024
pshenmic
previously approved these changes
Nov 18, 2024
pshenmic
approved these changes
Nov 18, 2024
This was referenced Nov 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We need to display withdrawals documents and status, but indexer does not contain this information and we need data about docs from dapi
Things done
Implemented method, which allows to get withdrawals from dapi. In the process of getting the hash of a transaction, we need to refer to the indexer and this method will take the hash from either the document or the transaction (if there is no document). This method allows us to save time in cases when our database contains a transaction document
Also has been added new method to DAPI for documents search
Updated Readme.md
Added integration tests for identity withdrawals