Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faster nbody tests #1365

Merged
merged 1 commit into from
Nov 26, 2018
Merged

faster nbody tests #1365

merged 1 commit into from
Nov 26, 2018

Conversation

alenaizan
Copy link
Contributor

Description

Previous nbody tests take long time. I have changed the methods, basis sets and/or molecules to make faster tests.

Status

  • Ready for review
  • Ready for merge

dgasmith
dgasmith approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loriab
loriab approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this’ll be better for routine testing. I’ll see about grabbing the orig for pytest. No worked example should go to waste.

@jturney jturney merged commit fb5d983 into psi4:master Nov 26, 2018
@loriab loriab added this to the Psi4 1.3 milestone Nov 26, 2018
@alenaizan alenaizan deleted the nbody branch December 4, 2018 22:19
@dgasmith dgasmith mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturney jturney jturney approved these changes

@dgasmith dgasmith dgasmith approved these changes

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Psi4 1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@alenaizan @jturney @dgasmith @loriab