Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network.py #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update network.py #8

wants to merge 1 commit into from

Conversation

DanBuchan
Copy link

As of torch 2.x torch.symeigh() is no longer available. torch.linalg.eigh can be used to replace this instead

As of torch 2.x torch.symeigh() is no longer available. torch.linalg.eigh can be used to replace this instead
@shaunmk
Copy link
Member

shaunmk commented Jan 17, 2025

Just leaving this note here for anyone who might consider this:

This change will indeed need to be pulled if we ever intend to support newer GPUs, for example.

However, I did test torch.linalg.eigh() when the deprecation was first announced; the output coordinates are not identical to those produced when symeig() is used, and there is a small drop in model accuracy w.r.t. symeig().

Ideally we would need to retrain/finetune the model with eigh as part of the compute graph in order to do this "properly".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants