Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file/handler #11

Open
AustinArey opened this issue Apr 27, 2023 · 1 comment · May be fixed by #21
Open

Add file/handler #11

AustinArey opened this issue Apr 27, 2023 · 1 comment · May be fixed by #21
Labels
⚡️ effort:medium enhancement New feature or request

Comments

@AustinArey
Copy link
Collaborator

Both some of the glob utilities and the markdown code block eval utilities would benefit from a standard interface for reading, writing, and evaluating files by file type.
@AustinArey AustinArey converted this from a draft issue Apr 27, 2023
@pskfyi pskfyi added this to the 0.3.0 milestone Apr 27, 2023
@pskfyi pskfyi linked a pull request Apr 29, 2023 that will close this issue
Draft
@pskfyi
Copy link
Owner

pskfyi commented Apr 29, 2023

I did significant work on this, which I've documented in #21. I now think that the original goal here was conflating multiple concerns - the benefits to md/script/evalCodeBlocks are very minimal, and the integrations with fs/glob and related utils will be tricky. I think this should be pushed off to 0.4.0 or later, and for 0.3.0 we should just extract the TS evaluation code from md/script/evalCodeBlocks to ts/evaluate, which will set up for md/script/evalCodeBlocks to handle multiple languages. Created #22 to track this.

@pskfyi pskfyi added the enhancement New feature or request label Apr 29, 2023
@pskfyi pskfyi removed this from the 0.3.0 milestone Apr 29, 2023
@pskfyi pskfyi moved this from 0.3.0 to 0.4.0 in handy roadmap Apr 29, 2023
@pskfyi pskfyi moved this from 0.4.0 to Beyond in handy roadmap May 2, 2023
@pskfyi pskfyi removed this from handy roadmap Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡️ effort:medium enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

init FileHandler pskfyi/handy
2 participants
@pskfyi @AustinArey