Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init FileHandler #21

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

init FileHandler #21

wants to merge 5 commits into from

Conversation

pskfyi
Copy link
Owner

@pskfyi pskfyi commented Apr 29, 2023

Closes #11

Release Notes Preview

  • feat(fs): init fileHandler (5f76976)

    • FileHandler type describes the shape of a handler.

    • FileExtensionHandler abstract class defines the shape of objects that care about file extensions and acts as a sane default implementation.

    • Evaluable mixin type provides a consistent interface for file types that can be evaluated. (ex. source code)

    • PlainTextFileHandler sample implementation with FileExtensionHandler and FileHandler also works as a base class for other handlers or a fallback handler.

    TODO: need unit tests for PlainTextFileHandler

  • feat(json): init; move types/json -> json/types (14c7813)

  • feat(json): add JsonFileHandler (d8a6740)

    TODO: add tests for .write()

    TODO: add readme entry

  • feat(ts): add TypeScriptFileHandler (35401f3)

  • test: namespace fixture data (64220d2)

@pskfyi pskfyi mentioned this pull request Apr 29, 2023
@pskfyi
Copy link
Owner Author

pskfyi commented Apr 29, 2023

Created #22, #23, #24, and #25 based on discoveries made during this PR.

Base automatically changed from 0.3.0 to main May 4, 2023 01:58
pskfyi added 2 commits May 5, 2023 20:55
- `FileHandler` type describes the shape of a handler.

- `FileExtensionHandler` abstract class defines the shape of objects that care about file extensions and acts as a sane default implementation.

- `Evaluable` mixin type provides a consistent interface for file types that can be evaluated. (ex. source code)

- `PlainTextFileHandler` sample implementation with `FileExtensionHandler` and `FileHandler` also works as a base class for other handlers or a fallback handler.

TODO: need unit tests for `PlainTextFileHandler`
@pskfyi pskfyi force-pushed the init-file-handler branch from 87f8257 to b9ec5d4 Compare May 6, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file/handler
1 participant