Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git/script/makeReleaseNotes should be able to include conventional commit footers #25

Closed
pskfyi opened this issue Apr 29, 2023 · 1 comment
Closed

git/script/makeReleaseNotes should be able to include conventional commit footers #25

pskfyi opened this issue Apr 29, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request
Milestone
0.3.0

Comments

@pskfyi
Copy link
Owner

pskfyi commented Apr 29, 2023

See: 87f8257

This would allow TODO items to appear in release notes previews in PRs, as well as common footers like BREAKING CHANGE and refs.

Might want this to be on by default, possibly even on and non-configurable. Arguably a bug that these are presently omitted.
@pskfyi pskfyi added bug Something isn't working enhancement New feature or request labels Apr 29, 2023
@pskfyi pskfyi added this to the 0.3.0 milestone Apr 29, 2023
@pskfyi pskfyi moved this to 0.3.0 in handy roadmap Apr 29, 2023
@pskfyi pskfyi mentioned this issue Apr 29, 2023
Draft
pskfyi added a commit that referenced this issue May 1, 2023
@pskfyi
feat(makeReleaseNotes): add inclusive and footers options; closes #24; …
7839429 
…closes #25
@pskfyi pskfyi mentioned this issue May 1, 2023
Merged
@pskfyi
Copy link
Owner Author

pskfyi commented May 2, 2023

Discussed and we're going to make this behavior default and, for now, non-configurable.

pskfyi added a commit that referenced this issue May 2, 2023
@pskfyi
fix(makeReleaseNotes): include commit footers; closes #25
8afe653
pskfyi added a commit that referenced this issue May 4, 2023
@pskfyi
fix(makeReleaseNotes): include commit footers; closes #25
97c0f90
@pskfyi pskfyi closed this as completed May 4, 2023
@github-project-automation github-project-automation bot moved this from 0.3.0 to Done in handy roadmap May 4, 2023
AustinArey pushed a commit that referenced this issue May 4, 2023
@pskfyi @AustinArey
fix(makeReleaseNotes): include commit footers; closes #25
f2c075f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
handy roadmap
Status: Done
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@pskfyi