Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance makeReleaseNotes #35

Merged
merged 2 commits into from
May 4, 2023
Merged

Enhance makeReleaseNotes #35

merged 2 commits into from
May 4, 2023

Conversation

pskfyi
Copy link
Owner

@pskfyi pskfyi commented May 1, 2023 •
edited
Loading

See: #24, #25

@pskfyi pskfyi force-pushed the enhance-makereleasenotes branch from 7839429 to dd11f50 Compare May 2, 2023 02:50
@pskfyi pskfyi changed the title feat(makeReleaseNotes): add inclusive and footers options Enhance makeReleaseNotes May 2, 2023
@pskfyi pskfyi marked this pull request as ready for review May 2, 2023 02:55
@pskfyi pskfyi requested a review from AustinArey May 2, 2023 02:55
@AustinArey
Copy link
Collaborator

The code looks great. I do have a silly question on this text grammar's "'s":
--types=feat,custom --custom="Custom's Section Heading"

@pskfyi
Copy link
Owner Author

pskfyi commented May 4, 2023

Copy-paste error from before 😅

AustinArey
AustinArey approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@AustinArey AustinArey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for answering my question.

@pskfyi pskfyi merged commit a0a477f into 0.3.0 May 4, 2023
@pskfyi pskfyi deleted the enhance-makereleasenotes branch May 4, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinArey AustinArey AustinArey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pskfyi @AustinArey