Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: namespace fixture data #52

Merged
merged 1 commit into from
May 7, 2023
Merged

test: namespace fixture data #52

merged 1 commit into from
May 7, 2023

Conversation

pskfyi
Copy link
Owner

@pskfyi pskfyi commented May 6, 2023 •
edited
Loading

Extracted from #21

This lays groundwork for other modules to use the fixture directory without affecting fs tests. Even if #21 never merges, other future modules will want to add fixture data, and when that happens they'll need this change to be in place.

@pskfyi pskfyi marked this pull request as ready for review May 6, 2023 04:15
@pskfyi pskfyi requested a review from AustinArey May 6, 2023 04:15
AustinArey
AustinArey approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@AustinArey AustinArey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

@AustinArey AustinArey merged commit 8f8285d into main May 7, 2023
@AustinArey AustinArey deleted the namespace-fixtures branch May 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinArey AustinArey AustinArey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pskfyi @AustinArey