Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json): init; move types/json -> json/types #51

Merged
merged 1 commit into from
May 8, 2023
Merged

feat(json): init; move types/json -> json/types #51

merged 1 commit into from
May 8, 2023

Conversation

pskfyi
Copy link
Owner

@pskfyi pskfyi commented May 6, 2023

Extracted from #21

@pskfyi pskfyi marked this pull request as ready for review May 6, 2023 04:08
@pskfyi pskfyi requested a review from AustinArey May 6, 2023 04:08
@pskfyi pskfyi marked this pull request as draft May 6, 2023 15:50
@pskfyi pskfyi removed the request for review from AustinArey May 6, 2023 15:50
@pskfyi
Copy link
Owner Author

pskfyi commented May 6, 2023

Moving this back to draft. I want to keep the types module for some forthcoming utility types. I'll edit this branch after that stuff lands.

@pskfyi
Copy link
Owner Author

pskfyi commented May 8, 2023

Upon further consideration, I'd rather park general utility types in ts/types now that ts exists as a top-level directory. So this PR is good to move forward.

@pskfyi pskfyi marked this pull request as ready for review May 8, 2023 04:38
@pskfyi pskfyi requested a review from AustinArey May 8, 2023 04:38
AustinArey
AustinArey approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@AustinArey AustinArey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AustinArey AustinArey merged commit d5b6167 into main May 8, 2023
@AustinArey AustinArey deleted the init-json branch May 8, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinArey AustinArey AustinArey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pskfyi @AustinArey