Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object/types): init #88

Merged
merged 2 commits into from
May 27, 2023
Merged

feat(object/types): init #88

merged 2 commits into from
May 27, 2023

Conversation

pskfyi
Copy link
Owner

@pskfyi pskfyi commented May 23, 2023

Extracted from #79.

  • feat(object/types): init

    • Key is a valid object key.

    • Entry is a key-value tuple.

    • Pair is a key-value pair in an object.

    • EntryToPair converts an Entry to a Pair

    • FromEntries converts Entrys to an object

    • ToEntries converts an object to an array of Entrys

    • The Obj namespace clusters these helper types.

@pskfyi pskfyi force-pushed the object-type-utils branch from a93b723 to 679f4ee Compare May 23, 2023 15:45
@pskfyi pskfyi marked this pull request as ready for review May 23, 2023 15:46
@pskfyi pskfyi requested a review from AustinArey May 23, 2023 15:46
@pskfyi pskfyi mentioned this pull request May 23, 2023
22 tasks
@pskfyi pskfyi removed the request for review from AustinArey May 26, 2023 00:44
@pskfyi pskfyi marked this pull request as draft May 26, 2023 00:44
object/types.ts Outdated Show resolved Hide resolved
@pskfyi pskfyi force-pushed the object-type-utils branch 2 times, most recently from 0d9846c to 29f466e Compare May 26, 2023 07:37
@pskfyi pskfyi marked this pull request as ready for review May 26, 2023 07:38
@pskfyi pskfyi requested a review from AustinArey May 26, 2023 07:38
@pskfyi pskfyi force-pushed the object-type-utils branch from 29f466e to 5b55f0a Compare May 27, 2023 08:13
- `Key` is a valid object key.

- `EmptyObject` is an object for which all properties are invalid.

- `Entry` is a key-value tuple.

- `Pair` is a key-value pair in an object.

- `EntryToPair` converts an `Entry` to a `Pair`

- `FromEntries` converts `Entry`s to an object

- `ToEntries` converts an object to an array of `Entry`s

- The `Obj` namespace clusters these helper types.
@pskfyi pskfyi force-pushed the object-type-utils branch from 5b55f0a to ceedbc9 Compare May 27, 2023 08:14
Copy link
Collaborator

@AustinArey AustinArey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AustinArey AustinArey merged commit 5da75ff into main May 27, 2023
@AustinArey AustinArey deleted the object-type-utils branch May 27, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants