Error when copying to a folder with spaces in its name

[SalimSalici]

Hi, I noticed that when I try to copy a file to a folder that has a spaces in its name, an error occurs.

After some debugging I discovered that these three lines of code (in the function actionCopy defined in connectors/php/LocalFileManager.php)

$target_input = $this->get['target'];
$target_path = $target_input . '/';
$target_path = $this->expandPath($target_path, true);

replace every space with an underscore. This is done by $this->expandPath($target_path, true);.

This line of code then $target_fullpath = $this->getFullPath($target_path, true); fails to find the requested path, because the folder name has been changed before by adding underscores.

By setting the second parameter of expandePath to false, the spaces don't get replaced and the copy works fine.

I'd like to know if this is the correct way to procede, or if I may run into some other problems (security issues for example).

Thank you.

[psolom]

It's a bug. The second parameter should be true only for new folders, not existing ones.
I have performed and committed a fix. Thanks for reporting.