Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file extensions filtering on clientside #205

Merged
merged 8 commits into from
Jul 24, 2017
Merged

Added file extensions filtering on clientside #205

merged 8 commits into from
Jul 24, 2017

Conversation

iruizmar
Copy link
Contributor

See #204 (Issue)

Filtering on config is just made as you suggested. Do you want me to upload the .default.json?

Ew... just realised I did this on my reformatted 2-space-correctly-tabbed file. Please, let me know if you want me to copy the changes into the other version.

Best regards.

@iruizmar iruizmar changed the title Added file extensions fitlering on clientside. Added file extensions filtering on clientside Jul 21, 2017
@psolom
Copy link
Owner

psolom commented Jul 21, 2017

Yeah, that's a mess ))
Please update your commit with original spaced file.

You could include .default.json as well

@iruizmar
Copy link
Contributor Author

iruizmar commented Jul 24, 2017

Well, the fix of the spaces mess took me longer than the commit itself :( ... I hope it is correctly done now. Please, let me know if not.

@psolom
Copy link
Owner

psolom commented Jul 24, 2017

I see, however finally you did it )
Thanks for your efforts. I will take a look your PR a bit later.

@psolom psolom changed the base branch from master to dev July 24, 2017 17:17
@psolom psolom merged commit 75ffd93 into psolom:dev Jul 24, 2017
@iruizmar iruizmar deleted the clientside-file-filtering branch July 25, 2017 06:16
@iruizmar iruizmar restored the clientside-file-filtering branch July 25, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants