Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD DIRECTORY EMPTY + FR (updated) +EL indent+ fix JSON error (cs,fi,hu) #28

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

fabriceci
Copy link
Contributor

@fabriceci fabriceci commented Aug 9, 2016

I add a entry DIRECTORY_EMPTY, to handle the case when you try to download a an empty directory (Zip).

I do on the way :

  • correction of a JSON Error on the file ( cs, fi, hu)
  • reindented the file el
  • completed the French translation

Suggestions (I did not do that is the PR) :

  • normalize files

    • uppercase or lowercase all keys
    • sometime there is %s and other time '%s'
      "DIRECTORY_ALREADY_EXISTS": "The directory '%s' already exists.",
      "DIRECTORY_NOT_EXIST": "The directory %s does not exist.",
    
  • rename (I think) summary_size="Size" to summary_size="Used space"

  • ask help on the homepage to complete translations

@psolom psolom added this to the 1.1.0 milestone Aug 16, 2016
@fabriceci
Copy link
Contributor Author

Have you some questions about this?

@psolom
Copy link
Owner

psolom commented Aug 23, 2016

No it's ok, I'm going to merge it in few days. Right after the merging the previos PR.

@psolom psolom merged commit 403175c into psolom:master Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants