Always build and use our version of pacman #12
Conversation
|
Closes #11 |
This might need some testing
|
Makepkg does actually use pacman-conf, though, although I'm not sure for what. This will return the wrong paths if pspdev had been moved. I'm not sure if this is a problem, I'll try to figure it out from the code. |
|
An update, I just checked. Makepkg only uses pacman-conf to check where the lockfile is. It only checks if the file exists (which it won't if PSPDEV is in a different location), but since pacman also checks for it, it should be fine if the check doesn't work. We could probably patch the check out. |
|
I did some additional testing based on your suggestions and I'd say we should either leave this as is or patch pacman a bit more. I think the wrapper script using some extra flags is probably preferred over increasing the amount of changes we make, but I'll leave that up to you @carstene1ns |
The previous solution was better, but doesn't work on Mac because of a bash version which is too old.
|
Okay, I've made some changes to prevent the issue on Mac and to prevent an issue when using sudo. It is not the cleanest solution, but it does work well and it should no longer be broken on Mac. |
|
Since the progress on Clang seems to have slowed down, we should probably see if we can merge this and with the rest of psp-pacman. |
|
I don't see any issues in adding psp-pacman to the repo, anyone else care to comment? |
|
Currently it brings no real improvements as all libraries are still built on each developer's machines. There are some open tasks yet. (e.g. repo) |
|
While it doesn't offer a big benefit yet to include it in the toolchain, this particular PR does not make it to it is part of it. I'm working on a way for us to set up a repo. I have a small scale prototype up here: https://github.com/sharkwouter/arch-repo-test We may be able to use a release on Github as a repository, but I'm not sure how many packages you could add to a release. Otherwise we could use S3, but that's only free for a year unfortunately, although not expensive. |
|
To clarify why this PR is still here and still needed. This PR simplifies psp-pacman and the scripts surrounding it and fixes the following issues:
|
John-K
left a comment
John-K
left a comment
There was a problem hiding this comment.
This seems fine, we should merge this and get this in the toolchain
|
Thanks @John-K, that made me able to merge this. |
I've tested this on Arch and Debian. It didn't seem to cause any issues for me.