Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest master doesn't compile if using WSL2 Ubuntu 24.0.4 official release #254

Closed
thearchivalone opened this issue Dec 16, 2024 · 7 comments

Comments

@thearchivalone
Copy link
Contributor

thearchivalone commented Dec 16, 2024

Description of Bug

PSPSDK fails to build due to zlib.h not being found

How to Reproduce

  1. Configure WSL2 on Windows
  2. Install / upgrade to Ubuntu 24.0.4
  3. Clone branch from repo
  4. Build and install all required prerequisites
  5. Run through the build process

Why Does This Happen

The build-essential package at one time installed the zlib-dev package by default. 24.0.4 switched the package to zlib1g-dev and removed it from build-essential.

Suggested Fix

Add a note to the documentation about this so that other people know to install the missing package before building. It's the only one like this. This issue was opened mostly to document that in case others run into the same issue.

Thanks for your time.

@diamant3
Copy link
Member

Thank you for the bug report! As of now it uses Ubuntu 22.04 in CI and will update/fix as soon as possible when ubuntu-latest is set to version 24.04.

Anyone is appreciated if they make a PR for notice but this bug report is sufficient for more breaking changes.

@sharkwouter
Copy link
Member

sharkwouter commented Dec 16, 2024

It does seem like the virtual package libz-dev still exists. We could use that. That should probably work for all Debian and Ubuntu based systems.

@diamant3
Copy link
Member

It does seem like the virtual package libz-dev still exists. We could use that.

Nice. If that's the case, I'll make a PR for that.

@thearchivalone
Copy link
Contributor Author

It does seem like the virtual package libz-dev still exists. We could use that.

Nice. If that's the case, I'll make a PR for that.

Very nice. I rarely use Ubuntu like this and forgot about virtual packages. That should help with backwards compatibility, right?

thearchivalone added a commit to thearchivalone/pspsdk that referenced this issue Dec 16, 2024
@sharkwouter
Copy link
Member

Exactly, then we don't have to specify a version and it works with older systems too.

@thearchivalone
Copy link
Contributor Author

I don't see anything else here. This is closeable for me unless there's something I missed.

@sharkwouter
Copy link
Member

Great! Thanks for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants