-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add other sceDisplay functions #248
base: master
Are you sure you want to change the base?
Conversation
I did a quick test to see if this interfered with existing functions, but I had no issue. I would like to see at least one or two test applications to make sure at least some of them work, though. I think |
I did some more testing and it seems that these are wrong unfortunately. The |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now these functions don't do what the titles say. Some don't even work. We should fix this first.
Well for one, I doubt all these functions have void arguments. For example sceDisplayGetBrightness seems to have two parameters from what I remember: https://github.com/joel16/CMFileManager-PSP/blob/next/display_driver/display_driver.c#L13 (This is the kernel mode equivalent though which I assume would be similar/same in usermode) |
Got it, and if no error codes returned, it means it's just a matter of function signature. I'll draft it and continue to work on this one. Thank you guys. |
Done. I checked them all one function at a time using my PSP slim(2000) and everything is usable except the Thanks to Joel16' CMFileManager display driver implementation, PPSSPP sceDisplay implementation and vita SDK docs. |
I might be completely wrong, and this is nothing than a mere speculation but sceDisplayGetResumeMode sounds like something for psp go's resume feature. |
That function is specific to psp go? Hopefully not.😢 Anyway, Is it much better if I remove that |
Unless we can get it tested somehow then I'd suggest we remove it. |
These are the last functions found in sceDisplay according from https://spenon-dev.github.io/PSPLibDoc/
, but these are all untested. Can we add them? thanks.