-
Notifications
You must be signed in to change notification settings - Fork 115
Implement transition
stats for the jira
plugin
#352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c47f414
to
92c5e82
Compare
verified
stats for the jira
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement! The custom verified_status
field looks good to me. Works nicely, I only ran into a problem when login
contained @
. Should be fixed by d339504.
For reference, the reported error was:
|
verified
stats for the jira
plugintransition_to
stats for the jira
plugin
@lukaszachy Your implementation makes sense, generally speaking. How about specifying important states by The idea of this issue #364 is to have for example something like this in the config:
Default (without |
List of interesting statuses sounds nice, it would give even a bit more flexibility to the user. |
Or like I guess I should update PR. |
Can you please rebase? |
7f77b82
to
92897c6
Compare
pre-commit is failing on:
|
92897c6
to
aac0405
Compare
squash: Quote user login in the query sq: rename option/plugin
Fixed in ef08f17. |
This sounds very nicely flexible!
I'd rather suggest to handle this in a separate pull request. We could have both target status (for basic use cases) and transition query (for more complex ones). In order to make the naming a bit more clear I've renamed the key to |
transition_to
stats for the jira
plugintransition_status
stats for the jira
plugin
transition_status
stats for the jira
plugintransition
stats for the jira
plugin
Should I make it more generic? As in 'JiraTransitioned' ? In theory one could have config with one project counting 'Release Pending' and another where 'Integration' is counted as the user's role is different
Config like
Seems that states and workflows can be too different