Skip to content

List resolved jiras also when user is specified as tester or contributor #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

Frawless
Copy link
Contributor

In our team we resolve jiras where the users of did are set as tester in some cases and not just as assignee - here is and example of task like that. To get these tasks as resolved via did we had to add these lines to the code (we maintained changes for some time).

Another option would be to introduce a new output like Issues Verified in Jira - XXX and put there all tasks where user is specified as tester.

@sandrobonazzola
Copy link
Collaborator

Can you please rebase?

@Frawless
Copy link
Contributor Author

Can you please rebase?

done :)

Copy link
Collaborator

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change in .gitignore and adding a suggestion as an alternative in jira plugin.

@Frawless Frawless changed the title List resolved jiras also when user is specified as tester List resolved jiras also when user is specified as tester or contributor May 22, 2025
@sandrobonazzola sandrobonazzola self-requested a review May 26, 2025 07:30
Copy link
Collaborator

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash and rebase?

@Frawless
Copy link
Contributor Author

@sandrobonazzola looks to me that the failures are not related to the change, maybe some env issue and restart will resolve it?

@sandrobonazzola
Copy link
Collaborator

Looks like errors are related to a GitHub plugin missing exception handling:

Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/did/plugins/github.py", line 176, in search
    data = json.loads(response.text)["items"]
  File "/usr/lib64/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

with GitHub not being collaborative today.

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@sandrobonazzola sandrobonazzola merged commit 58415f9 into psss:main May 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants