Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE gems #284

Merged
merged 1 commit into from
Nov 20, 2020
Merged

UPDATE gems #284

merged 1 commit into from
Nov 20, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Oct 13, 2020

@cdmo cdmo added this to the 0.3.x Theming and Final Prep milestone Oct 13, 2020
@cdmo cdmo requested a review from banukutlu October 13, 2020 12:54
@cdmo cdmo self-assigned this Oct 13, 2020
@cdmo cdmo marked this pull request as draft October 27, 2020 16:15
@cdmo cdmo force-pushed the update-gems branch 2 times, most recently from d18c5fb to 594bec7 Compare November 18, 2020 17:43
@cdmo
Copy link
Contributor Author

cdmo commented Nov 18, 2020 •
edited
Loading

regarding changes to let limits:

Note: let can enhance readability when used sparingly (1,2, or maybe 3 declarations) in any given example group, but that can quickly degrade with overuse. YMMV.

source

and

Until you need to break out the big guns like shared examples, avoid DSL constructs like subject, let, its, and before. Stick to your old friends: variables, methods, and classes.

src

Read through this too: rubocop/rubocop-rspec#862

I think let can be confusing and should definitely not be used if there are no cases where the variable is not loaded anyway (or always loaded), which we had a bunch of.

@cdmo cdmo marked this pull request as ready for review November 18, 2020 17:48
UPDATE gems
ef0e944 
* actioncable 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actioncable/CHANGELOG.md#rails-6034-october-07-2020)

* actionmailbox 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actionmailbox/CHANGELOG.md#rails-6034-october-07-2020)

* actionmailer 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actionmailer/CHANGELOG.md#rails-6034-october-07-2020)

* actionpack 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actionpack/CHANGELOG.md#rails-6034-october-07-2020)

* actiontext 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actiontext/CHANGELOG.md#rails-6034-october-07-2020)

* actionview 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/actionview/CHANGELOG.md#rails-6034-october-07-2020)

* activejob 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/activejob/CHANGELOG.md#rails-6034-october-07-2020)

* activemodel 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/activemodel/CHANGELOG.md#rails-6034-october-07-2020)

* activerecord 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/activerecord/CHANGELOG.md#rails-6034-october-07-2020)

* activestorage 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/activestorage/CHANGELOG.md#rails-6034-october-07-2020)

* activesupport 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/activesupport/CHANGELOG.md#rails-6034-october-07-2020)

* better_errors 2.7.1 → 2.8.3
[changelog](https://github.com/BetterErrors/better_errors/blob/master/CHANGELOG.md)

* bootsnap 1.4.6 → 1.4.8
[changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md#148)

* capybara 3.32.2 → 3.33.0
[changelog](https://github.com/teamcapybara/capybara/blob/master/History.md#version-3330)

* crack 0.4.3 → 0.4.4
[changelog](https://github.com/jnunemaker/crack/blob/master/History)

* ddtrace 0.40.0 → 0.41.0
[changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md#0410---2020-09-30)

* diff-lcs 1.3 → 1.4.4
[changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md#144--2020-07-01)

* dry-configurable 0.11.5 → 0.11.6
[changelog](https://github.com/dry-rb/dry-configurable/blob/master/changelog.yml)

* dry-initializer 3.0.3 → 3.0.4
[changelog](https://github.com/dry-rb/dry-initializer/blob/master/changelog.yml)

* dry-logic 1.0.6 → 1.0.8
[changelog](https://github.com/dry-rb/dry-logic/blob/master/changelog.yml)

* dry-schema 1.5.1 → 1.5.5
[changelog](https://github.com/dry-rb/dry-schema/blob/master/changelog.yml)

* dry-validation 1.5.1 → 1.5.6
[changelog](https://github.com/dry-rb/dry-validation/blob/master/changelog.yml)

* erb_lint 0.0.34 → 0.0.35

* factory_bot 5.2.0 → 6.1.0
[changelog](https://github.com/thoughtbot/factory_bot/blob/master/NEWS.md#610-july-8-2020)

* factory_bot_rails 5.2.0 → 6.1.0
[changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md#610-july-8-2020)

* json 2.3.0 → 2.3.1
[changelog](https://github.com/flori/json/blob/master/CHANGES.md#2020-06-30-231)

* nio4r 2.5.3 → 2.5.4
[changelog](https://github.com/socketry/nio4r/blob/v2.5.4/CHANGES.md#254-2020-09-16)

* parser 2.7.1.3 → 2.7.2.0
[changelog](https://github.com/whitequark/parser/blob/v2.7.2.0/CHANGELOG.md)

* public_suffix 4.0.5 → 4.0.6
[changelog](https://github.com/weppos/publicsuffix-ruby/blob/v4.0.6/CHANGELOG.md#406)

* rack-protection 2.0.8.1 → 2.1.0

* rails 6.0.3.3 → 6.0.3.4

* rails-controller-testing 1.0.4 → 1.0.5

* railties 6.0.3.3 → 6.0.3.4
[changelog](https://github.com/rails/rails/blob/v6.0.3.4/railties/CHANGELOG.md#rails-6034-october-07-2020)

* redis 4.2.1 → 4.2.2
[changelog](https://github.com/redis/redis-rb/blob/v4.2.2/CHANGELOG.md#422)

* regexp_parser 1.7.1 → 1.8.2
[changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md#182---2020-10-11---janosch-müller)

* rspec-core 3.9.2 → 3.9.3
[changelog](https://github.com/rspec/rspec-core/blob/main/Changelog.md)

* rubocop 0.85.1 → 0.93.1
[changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0931-2020-10-12)

* rubocop-ast 0.0.3 → 0.8.0
[changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md#080-2020-10-12)

* rubocop-performance 1.6.1 → 1.8.1
[changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md#181-2020-09-19)

* rubocop-rails 2.6.0 → 2.8.1
[changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md#281-2020-09-16)

* rubocop-rspec 1.40.0 → 1.43.2
[changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md#1432-2020-08-25)

* sidekiq 6.1.1 → 6.1.2
[changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md#612)

* sinatra 2.0.8.1 → 2.1.0
[changelog](https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md#210--2020-09-05)

* spring 2.1.0 → 2.1.1
[changelog](https://github.com/rails/spring/blob/master/CHANGELOG.md#211)

* sprockets-rails 3.2.1 → 3.2.2

* view_component 2.18.0 → 2.19.1
[changelog](https://github.com/github/view_component/blob/master/CHANGELOG.md#2191)

* warden 1.2.8 → 1.2.9
[changelog](https://github.com/wardencommunity/warden/blob/master/CHANGELOG.md#version-129--2020-08-31)

* webmock 3.8.3 → 3.9.2
[changelog](https://github.com/bblimke/webmock/blob/v3.9.2/CHANGELOG.md#392)

* webpacker 5.1.1 → 5.2.1
[changelog](https://github.com/rails/webpacker/blob/v5.2.1/CHANGELOG.md#521---2020-08-17)

* better_errors 2.8.3 → 2.9.1
[changelog](https://github.com/BetterErrors/better_errors/blob/master/CHANGELOG.md)

* bootsnap 1.4.8 → 1.5.1
[changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md#151)

* ddtrace 0.41.0 → 0.42.0
[changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md#0420---2020-10-21)

* dry-schema 1.5.5 → 1.5.6
[changelog](https://github.com/dry-rb/dry-schema/blob/master/changelog.yml)

* erubi 1.9.0 → 1.10.0
[changelog](https://github.com/jeremyevans/erubi/blob/master/CHANGELOG)

* faraday 1.0.1 → 1.1.0
[changelog](https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v0110)

* http-parser 1.2.1 → 1.2.2

* octokit 4.18.0 → 4.19.0

* parallel 1.19.2 → 1.20.0

* redis 4.2.2 → 4.2.3
[changelog](https://github.com/redis/redis-rb/blob/v4.2.3/CHANGELOG.md#423)

* rspec-core 3.9.3 → 3.10.0
[changelog](https://github.com/rspec/rspec-core/blob/main/Changelog.md#3100--2020-10-30)

* rspec-expectations 3.9.2 → 3.10.0
[changelog](https://github.com/rspec/rspec-expectations/blob/main/Changelog.md#3100--2020-10-30)

* rspec-mocks 3.9.1 → 3.10.0
[changelog](https://github.com/rspec/rspec-mocks/blob/main/Changelog.md#3100--2020-10-30)

* rspec-support 3.9.3 → 3.10.0
[changelog](https://github.com/rspec/rspec-support/blob/main/Changelog.md#3100--2020-10-30)

* rubocop-ast 0.8.0 → 1.1.1
[changelog](https://github.com/rubocop-hq/rubocop-ast/tree/master/changelog)

* rubocop-performance 1.8.1 → 1.9.0
[changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md#190-2020-11-17)

* rubocop-rspec 1.43.2 → 1.44.1
[changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md#1441-2020-10-20)

* tzinfo 1.2.7 → 1.2.8
[changelog](https://github.com/tzinfo/tzinfo/blob/v2.0.3/CHANGES.md#version-128---8-nov-2020)

* view_component 2.19.1 → 2.22.1
[changelog](https://github.com/github/view_component/blob/master/CHANGELOG.md#2221)

* webmock 3.9.2 → 3.10.0
[changelog](https://github.com/bblimke/webmock/blob/v3.10.0/CHANGELOG.md#3100)

* zeitwerk 2.4.0 → 2.4.1
[changelog](https://github.com/fxn/zeitwerk/blob/master/CHANGELOG.md#241-29-october-2020)

Also:

* Removes octokit
* Rubocop fixes, mostly RSpec/MultipleMemoizedHelpers violations
banukutlu
banukutlu reviewed Nov 18, 2020
View reviewed changes
app/models/call.rb
fields.dig('itemList')
fields['itemList']
Copy link
Contributor

@banukutlu banukutlu Nov 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no digging 👀 guess it is because it is a single dig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... makes sense, no digging on single item targets.

banukutlu
banukutlu approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@cdmo
Copy link
Contributor Author

cdmo commented Nov 20, 2020

um, LGTM?

@banukutlu banukutlu merged commit 237b22f into master Nov 20, 2020
@banukutlu banukutlu deleted the update-gems branch November 20, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banukutlu banukutlu banukutlu approved these changes

Assignees

@cdmo cdmo

Labels
None yet
Projects
None yet
Milestone
1.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmo @banukutlu