KBI0028: Notes on Sciebo/Nextcloud share URLs #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsheunis
requested changes
Jul 19, 2023
|
This KBI made me think that something like a |
|
super insightful! Thanks for writing this up! |
Co-authored-by: Stephan Heunis <s.heunis@fz-juelich.de>
|
Thanks for the reviews! @jsheunis I applied most of your suggestions, but then pushed further tweaks, sometimes refining the suggestions further. I rejected the suggestion in introduction, but pushed a change that's similar in spirit while remaining a short paragraph (note that |
jsheunis
approved these changes
Jul 20, 2023
Discovered that by accident today - registered URL would be urlquoted anyway, plus uncurl tries to split the match pattern into match patterns.
|
Thanks again for the reviews, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not come up as a support event (i.e. "nobody asked for this"), but this goes back to something we considered for an archival request (internal issue tracker) and something I later explored for myself, so I think knowledge base is an useful place to document that with better visibility.
Features Nextcloud / Sciebo specific details, and a practical example of an uncurl remote. Writing it up was very educational for me.