Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV build broken due to once_cell v1.15 #756

Closed
psychon opened this issue Sep 22, 2022 · 2 comments · Fixed by #758
Closed

MSRV build broken due to once_cell v1.15 #756

psychon opened this issue Sep 22, 2022 · 2 comments · Fixed by #758

Comments

@psychon
Copy link
Owner

psychon commented Sep 22, 2022

A new Rust release means that some new clippy complaints from the clippy beta will show up, so I re-triggered the latest build. The latest successful action run used once_cell v1.14.0. The newest run failed in the msrv check with a newer version:

Downloading crates ...
  Downloaded once_cell v1.15.0
error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/once_cell-1.15.0/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.

See matklad/once_cell#201
@notgull
Copy link
Collaborator

notgull commented Sep 22, 2022

There are three real options here:

  • Bump the MSRV to 1.56
  • Pin once_cell to 1.14
  • Create a Cargo.lock.MSRV that uses 1.14 for MSRV tests and 1.15 for everything else

Personally I'd prefer the 1st option. Many crates (notable libc) are planning bumps to a 1.5x version in the near future, so we might as well bump now.

@psychon
Copy link
Owner Author

psychon commented Sep 23, 2022

The first two options are fine with me, but the third one sounds complicated and smol-rs/async-io#93 (comment) says that it is hard to use/do.

psychon added a commit that referenced this issue Sep 23, 2022
@psychon
Bump MSRV to 1.56
3c209ad 
once_cell v1.15 switched to the 2021 edition and thus requires at least
Rust 1.56 to build. This commit increases our MSRV accordingly.

Fixes: #756
Signed-off-by: Uli Schlachter <psychon@znc.in>
@psychon psychon mentioned this issue Sep 23, 2022
Merged
@notgull notgull mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump MSRV to 1.56
2 participants
@psychon @notgull