Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Buffer and use an associated type in the RequestConnection trait #259

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Get rid of Buffer and use an associated type in the RequestConnection trait #259

merged 1 commit into from
Mar 7, 2020

Conversation

eduardosm
Copy link
Collaborator

No description provided.

@eduardosm
Copy link
Collaborator Author

eduardosm commented Mar 7, 2020 •
edited
Loading

Regarding GenericEvent and GenericErrors, I had to remove the TryFrom and Into implementations for the same reasons as in #251 (comment). Instead, I added non-trait methods.

psychon
psychon reviewed Mar 7, 2020
View reviewed changes
src/cookie.rs Outdated Show resolved Hide resolved
psychon
psychon reviewed Mar 7, 2020
View reviewed changes
src/utils.rs Show resolved Hide resolved
@psychon
Copy link
Owner

psychon commented Mar 7, 2020

I am not too happy about all the errors and events now needing a type parameter, but... meh, whatever. It's worth it.

@eduardosm
Copy link
Collaborator Author

I am not too happy about all the errors and events now needing a type parameter, but... meh, whatever. It's worth it.

I'm afraid its the only way. But I also think it is worth.

@psychon psychon merged commit e7ed7bc into psychon:master Mar 7, 2020
@eduardosm eduardosm deleted the buffer branch March 7, 2020 20:15
@eduardosm eduardosm mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychon psychon psychon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardosm @psychon