Fix unused_qualifications warnings on Windows and exclude extract-generated-code-doc and generator from clippy's MSRV check #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not quite sure why, but CI started failing on windows. The
previous, successful build used Rust 1.77.2 and now with 1.78.0, the
build fail. I do not know whether this is really the reason, but it is
my best guess.
The compiler error message looks like this:
error: unnecessary qualification
--> x11rb\src\rust_connection\stream.rs:430:47
|
430 | Err(ref e) if e.kind() == std::io::ErrorKind::Interrupted => {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> x11rb\src\lib.rs:129:5
|
129 | unused_qualifications,
| ^^^^^^^^^^^^^^^^^^^^^
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
Clippy reports:
warning: usage of a legacy numeric constant
--> x11rb-async/src/rust_connection/mod.rs:630:40
|
630 | ... .unwrap_or(std::usize::MAX);
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
630 | .unwrap_or(usize::MAX);
| ~~~~~~~~~~
Signed-off-by: Uli Schlachter <psychon@znc.in>
Clippy nightly reports e.g.:
warning: doc list item missing indentation
--> x11rb-protocol/src/protocol/xproto.rs:1325:5
|
1325 | /// which was pressed.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
1325 | /// which was pressed.
| ++
Signed-off-by: Uli Schlachter <psychon@znc.in>
Clippy nightly reports e.g.:
warning: doc list item missing indentation
--> x11rb-protocol/src/protocol/xproto.rs:8386:5
|
8386 | /// windows created by other clients to your save set.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
8386 | /// windows created by other clients to your save set.
| ++
Signed-off-by: Uli Schlachter <psychon@znc.in>
Clippy nightly reports e.g:
warning: doc list item missing indentation
--> x11rb-async/src/lib.rs:40:5
|
40 | //! [`blocking::BlockingConnection`] for [`x11rb::xcb_ffi::XCBConnection`]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
40 | //! [`blocking::BlockingConnection`] for [`x11rb::xcb_ffi::XCBConnection`]
| ++
Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite sure why, but CI started failing on windows. The previous, successful build used Rust 1.77.2 and now with 1.78.0, the build fail. I do not know whether this is really the reason, but it is my best guess.
The compiler error message looks like this: