Fixed version regexp to match "10devel" #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also normalized the result and made sure that if PostgreSQL ever starts using just integer version numbers (as in "10") everything still works.
openstack-gerrit
pushed a commit
to openstack/taskflow
that referenced
this pull request
May 6, 2019
We have jsonschema capped at a fairly old version. Other than some specific releases, it looks like keeping it below 3.0 was added in I943fd68b9fab3bce1764305a5058df5339470757 without really any explanation why. In order to update to a 3.x release we need to: 1. Remove the cap from global-requirements.txt (see Depends-On), leaving upper-constraints.txt at a 2.x release 2. Remove the cap from all consumers (this change) 3. Release a new version of consumers that are published to pypi 4. Update upper-constraints.txt with those new releases 5. Update jsonschema in upper-constraints.txt to a 3.X release (See: https://review.openstack.org/649789) 6. Test consumers with the change from 5. 7. [Optional] fix issues in consumers that arise from 6. 8. Merge the change from 5. Also includes squashed commit: Raise lower constraint of psycopg2 Versions prior to 3.7 did not support postgresql version numbering starting with postgresql 10, causing setup failures. This raises the lower-constraint to the first version that contained the fix [0] to support that. With the change in global requirements for jsonschema, requirements check fails on raising psycopg2, but we need that raised in order for the jsonschema version to be raised. [0] psycopg/psycopg2#504 Also required updating networkx constraints to match current g-r. Change-Id: Ifd0f0586f945d1da4dd597ae7b4514117cd49f57 Co-Authored-by: Sean McGinnis <sean.mcginnis@gmail.com> Depends-On: https://review.openstack.org/649669
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
May 6, 2019
* Update taskflow from branch 'master'
- Merge "Uncap jsonschema"
- Uncap jsonschema
We have jsonschema capped at a fairly old version. Other than some
specific releases, it looks like keeping it below 3.0 was added in
I943fd68b9fab3bce1764305a5058df5339470757 without really any explanation
why.
In order to update to a 3.x release we need to:
1. Remove the cap from global-requirements.txt (see Depends-On), leaving
upper-constraints.txt at a 2.x release
2. Remove the cap from all consumers (this change)
3. Release a new version of consumers that are published to pypi
4. Update upper-constraints.txt with those new releases
5. Update jsonschema in upper-constraints.txt to a 3.X release
(See: https://review.openstack.org/649789)
6. Test consumers with the change from 5.
7. [Optional] fix issues in consumers that arise from 6.
8. Merge the change from 5.
Also includes squashed commit:
Raise lower constraint of psycopg2
Versions prior to 3.7 did not support postgresql version numbering
starting with postgresql 10, causing setup failures. This raises the
lower-constraint to the first version that contained the fix [0] to
support that.
With the change in global requirements for jsonschema, requirements
check fails on raising psycopg2, but we need that raised in order for
the jsonschema version to be raised.
[0] psycopg/psycopg2#504
Also required updating networkx constraints to match current g-r.
Change-Id: Ifd0f0586f945d1da4dd597ae7b4514117cd49f57
Co-Authored-by: Sean McGinnis <sean.mcginnis@gmail.com>
Depends-On: https://review.openstack.org/649669
- OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:
http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html
Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
openstack-gerrit
pushed a commit
to openstack/taskflow
that referenced
this pull request
May 6, 2019
Versions prior to 3.7 did not support postgresql version numbering starting with postgresql 10, causing setup failures. This raises the lower-constraint to the first version that contained the fix [0] to support that. With the change in global requirements for jsonschema, requirements check fails on raising psycopg2, but we need that raised in order for the jsonschema version to be raised. [0] psycopg/psycopg2#504 NOTE: Modified from merge to master branch due to the need to squash both this change with a change to uncap jsonschema to get tests to pass. This is the extraction of just the psycopg2 change that would have been done alone in I779ba615c5905eca23ab5074a08483dccc60db10. (cherry picked from commit 9ea4dae) Change-Id: I5000833b802a631e6bb1dbe234ea7d6881e769bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also normalized the result and made sure that if PostgreSQL ever starts
using just integer version numbers (as in "10") everything still works.