Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User friendly #3

Merged
merged 91 commits into from
Dec 23, 2021
Merged

User friendly #3

merged 91 commits into from
Dec 23, 2021

Conversation

pszemraj
Copy link
Owner

user-friendly

  • πŸ’– overall major rewrites to codebase to improve user experience / make it easier to understand things
  • ✨ add arguments for calling the main transcription script
  • β™Ώ : remove extra scripts, vid2cleantxt/transcribe.py now main script for transcription
  • ⚑ greatly streamlined the process of converting video -> audio
  • ✨ add support for audio files in addition to video files
  • πŸ› fixed issue where the large model was not using the attention mask
  • πŸ—ƒοΈ β™Ώ updated examples, and πŸ”₯ large video files from repo itself (can still be downloaded with added scripts)
  • πŸ’‘ πŸ“ added tons of docstrings to explain what functions do (thanks, copilot!)
  • ✏️ 🎨 cleaned up and modified code to be more readable, and more!

peter szemraj added 30 commits December 12, 2021 04:41
@pszemraj pszemraj self-assigned this Dec 20, 2021
@pszemraj
Copy link
Owner Author

Issue to fix #1 - if user does not have NVIDIA drivers installed, checking for cuda causes crash

see colab notebook here

@pszemraj
Copy link
Owner Author

issue to fix #2 - need to synchronize which tensors are passed to CUDA and which are not

see colab notebook for this issue here

@pszemraj
Copy link
Owner Author

Issue to fix #1 - if user does not have NVIDIA drivers installed, checking for cuda causes crash

see colab notebook here

resolved, see same link

@pszemraj
Copy link
Owner Author

issue to fix #2 - need to synchronize which tensors are passed to CUDA and which are not

see colab notebook for this issue here

resolved, see same colab link for test results

@pszemraj pszemraj merged commit cd8e45b into master Dec 23, 2021
@pszemraj pszemraj deleted the user-friendly branch December 23, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant