refactor: Fix simpler code structure/linting issues

Fixes #761
ptarmiganlabs · Aug 21, 2023 · c24c446 · c24c446
1 parent a0761cb
commit c24c446
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 9 deletions.
diff --git a/src/lib/msteams_notification.js b/src/lib/msteams_notification.js
@@ -440,7 +440,7 @@ function sendReloadTaskFailureNotificationTeams(reloadParams) {
                 scriptLogData.scriptLogHeadCount = globals.config.get('Butler.teamsNotification.reloadTaskFailure.headScriptLogLines');
                 scriptLogData.scriptLogTailCount = globals.config.get('Butler.teamsNotification.reloadTaskFailure.tailScriptLogLines');
 
-                scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');;
+                scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');
                 scriptLogData.scriptLogTail = scriptLogData.scriptLogFull
                     .slice(Math.max(scriptLogData.scriptLogFull.length - scriptLogData.scriptLogTailCount, 0))
                     .join('\r\n');
@@ -573,7 +573,7 @@ function sendReloadTaskAbortedNotificationTeams(reloadParams) {
                 scriptLogData.scriptLogHeadCount = globals.config.get('Butler.teamsNotification.reloadTaskAborted.headScriptLogLines');
                 scriptLogData.scriptLogTailCount = globals.config.get('Butler.teamsNotification.reloadTaskAborted.tailScriptLogLines');
 
-                scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');;
+                scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');
                 scriptLogData.scriptLogTail = scriptLogData.scriptLogFull
                     .slice(Math.max(scriptLogData.scriptLogFull.length - scriptLogData.scriptLogTailCount, 0))
                     .join('\r\n');

diff --git a/src/lib/scriptlog.js b/src/lib/scriptlog.js
@@ -33,6 +33,7 @@ function compareTaskDetails(a, b) {
     return 0;
 }
 
+// eslint-disable-next-line no-unused-vars
 function delay(milliseconds) {
     return new Promise((resolve) => {
         setTimeout(resolve, milliseconds);

diff --git a/src/lib/slack_api.js b/src/lib/slack_api.js
@@ -26,7 +26,6 @@ async function slackSend(slackConfig, logger) {
 
         const res = await axios.post(slackConfig.webhookUrl, JSON.stringify(body));
         logger.debug(`SLACKSEND: Result from POST to Slack webhook: ${res.statusText} (${res.status}): ${res.data}`);
-        return res;
     } catch (err) {
         logger.error(`SLACKSEND: ${err}"`);
     }

diff --git a/src/lib/smtp.js b/src/lib/smtp.js
@@ -496,7 +496,7 @@ async function sendReloadTaskFailureNotificationEmail(reloadParams) {
     scriptLogData.scriptLogHeadCount = globals.config.get('Butler.emailNotification.reloadTaskFailure.headScriptLogLines');
     scriptLogData.scriptLogTailCount = globals.config.get('Butler.emailNotification.reloadTaskFailure.tailScriptLogLines');
 
-    scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');;
+    scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');
     scriptLogData.scriptLogTail = scriptLogData.scriptLogFull
         .slice(Math.max(scriptLogData.scriptLogFull.length - scriptLogData.scriptLogTailCount, 0))
         .join('\r\n');
@@ -723,7 +723,7 @@ async function sendReloadTaskAbortedNotificationEmail(reloadParams) {
     scriptLogData.scriptLogHeadCount = globals.config.get('Butler.emailNotification.reloadTaskAborted.headScriptLogLines');
     scriptLogData.scriptLogTailCount = globals.config.get('Butler.emailNotification.reloadTaskAborted.tailScriptLogLines');
 
-    scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');;
+    scriptLogData.scriptLogHead = scriptLogData.scriptLogFull.slice(0, scriptLogData.scriptLogHeadCount).join('\r\n');
     scriptLogData.scriptLogTail = scriptLogData.scriptLogFull
         .slice(Math.max(scriptLogData.scriptLogFull.length - scriptLogData.scriptLogTailCount, 0))
         .join('\r\n');

diff --git a/src/lib/winsvc.js b/src/lib/winsvc.js
@@ -60,10 +60,12 @@ function exists(serviceName, host = null) {
             // On success, check
             (allServices) => {
                 // Find provided name
-                for (let i = 0; i < allServices.length; i++) {
+                for (let i = 0; i < allServices.length; ) {
                     if (allServices[i] === serviceName) {
                         resolve(true);
                     }
+
+                    i += 1;
                 }
 
                 // Not found, resolve false

diff --git a/src/plugins/sensible.js b/src/plugins/sensible.js
@@ -5,7 +5,8 @@ const fp = require('fastify-plugin');
  *
  * @see https://github.com/fastify/fastify-sensible
  */
-module.exports = fp(async (fastify, opts) => {
+// eslint-disable-next-line no-unused-vars
+module.exports = fp(async (fastify, _opts) => {
     // eslint-disable-next-line global-require
     await fastify.register(require('@fastify/sensible'), {
         errorHandler: false,

diff --git a/src/plugins/support.js b/src/plugins/support.js
@@ -3,7 +3,8 @@ const fp = require('fastify-plugin');
 // the use of fastify-plugin is required to be able
 // to export the decorators to the outer scope
 
-module.exports = fp(async (fastify, opts) => {
+// eslint-disable-next-line no-unused-vars
+module.exports = fp(async (fastify, _opts) => {
     // eslint-disable-next-line arrow-body-style
     fastify.decorate('someSupport', () => {
         return 'hugs';

diff --git a/src/udp/udp_handlers.js b/src/udp/udp_handlers.js
@@ -1,6 +1,5 @@
 // Load global variables and functions
 const globals = require('../globals');
-const QrsInteract = require('qrs-interact');
 const smtp = require('../lib/smtp');
 const slack = require('../lib/slack_notification');
 const webhookOut = require('../lib/webhook_notification');