Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in Butler when starting Sense tasks #101

Closed
mountaindude opened this issue Nov 13, 2020 · 0 comments
Closed

Memory leak in Butler when starting Sense tasks #101

mountaindude opened this issue Nov 13, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@mountaindude
Copy link
Collaborator

mountaindude commented Nov 13, 2020

Describe the bug
There is a slight memory leak that occurred when Sense tasks were started using Butler's API endpoint for this purpose.
Nothing major but still something that should be addressed.
https://github.com/ptarmiganlabs/butler/blob/master/src/qrsUtil/senseStartTask.js

The issue occurs when the options object is mutated and then passed to the Sense APIs over https.
Also, this code does not use the config data already loaded into the config object, but rather loads the data again. Inefficient.

Suggested solution:
Refactor the code, possibly using QRS Interact module instead of https calls. Would give better CORS handling among other things.

@mountaindude mountaindude added this to the 4.2 milestone Nov 13, 2020
@mountaindude mountaindude self-assigned this Nov 13, 2020
@mountaindude mountaindude mentioned this issue Nov 16, 2020
mountaindude added a commit that referenced this issue Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant