Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if Butler is running on Linux-ish system *and* UNC path is specified in approved list or as REST call parameter #522

Closed
mountaindude opened this issue Aug 6, 2022 · 1 comment · Fixed by #525, #526 or #529
Closed

Warn if Butler is running on Linux-ish system *and* UNC path is specified in approved list or as REST call parameter #522

mountaindude opened this issue Aug 6, 2022 · 1 comment · Fixed by #525, #526 or #529
Assignees
@mountaindude
Labels
enhancement
Milestone
8.4.0

Comments

@mountaindude
Copy link
Collaborator

Linux and macOS don't handle UNC paths well.
On these systems a remove file server should be mounted in the file system, then Butler can access the file share from there.

Output warnings to console and file log (if enabled).
@mountaindude mountaindude self-assigned this Aug 6, 2022
@mountaindude mountaindude added this to the 8.4.0 milestone Aug 6, 2022
@mountaindude mountaindude changed the title - Warn if Butler is running on Linux-ish system *and* UNC path is specified in approved list or as REST call parameter Warn if Butler is running on Linux-ish system *and* UNC path is specified in approved list or as REST call parameter Aug 6, 2022
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 7, 2022
@mountaindude
feat: Warn if UNC paths used with file API calls when Butler runs on …
843f781 
…non-Windows OS

Implements ptarmiganlabs#522
mountaindude added a commit to mountaindude/butler that referenced this issue Aug 7, 2022
@mountaindude
Better OS detection for ptarmiganlabs#522
1779390
@mountaindude
Copy link
Collaborator Author

Design notes

  • When reading file copy/move/delete allowed directories from config file AND the operating system Butler is running on is not Windows:
    • Warn in console and log file that UNC paths are not supported for non-Windows OSs.
  • When handling a call to the REST API endpoint for file copy/move/delete:
    • Warn in console and log file that UNC paths are not supported for non-Windows OSs.
    • Return http error 400 to calling client

mountaindude added a commit to mountaindude/butler that referenced this issue Aug 7, 2022
@mountaindude
Better OS detection for ptarmiganlabs#522
dd17bb9
@github-actions github-actions bot mentioned this issue Aug 7, 2022
Merged
This was referenced Aug 7, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 3, 2022
Merged
@github-actions github-actions bot mentioned this issue May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountaindude mountaindude

Labels
enhancement
Projects
None yet
Milestone
8.4.0
1 participant
@mountaindude