Update storage.go

[mholt]

Recent changes (not yet tagged) in CertMagic add context.Context to the Storage interface methods, as well as make use of the new fs.ErrNotExist error value.

Because it's a breaking change in CertMagic (which is not yet a stable 1.0), I'm submitting this PR as a courtesy. It's a quick edit I made manually in the browser, so it may need a little massaging if I missed something. Let me know if you have any questions!

(I only added context to your function signatures so they would be compatible with the updated interface. You might want to consider actually using the context for cancellation, if possible, when you get a chance. Thanks!)

[pteich]

Thanks @mholt I'll have a look at it and get back to you if I need some clarification.

[mholt]

Hey @pteich I think I might have the updated API go out with the 2.5 release of Caddy (and the 0.16 release of CertMagic). Anything you need from me to get this merged?

[pteich]

@mholt I'm sorry I forgot about that with all the daily business. I's merged now and I'll take care of proper context usage in a follow up. Thanks again for your work and the ping. :)

[mholt]

No worries, I know how it goes! Thanks! Your plugin is decently popular so I wanted to ensure we didn't leave it behind.

[pteich]

@mholt Are the changes regarding CertMagic already in the Caddy master branch? Because I'm getting messages like this when I use go get -u on the Caddy dependency:

../../go/pkg/mod/github.com/caddyserver/caddy/v2@v2.5.0-beta.1.0.20220325045403-a58f240d3ecb/caddy.go:639:27: not enough arguments in call to certmagic.CleanUpOwnLocks
        have (*zap.Logger)
        want (context.Context, *zap.Logger)
../../go/pkg/mod/github.com/caddyserver/caddy/v2@v2.5.0-beta.1.0.20220325045403-a58f240d3ecb/sigtrap_posix.go:39:30: not enough arguments in call to certmagic.CleanUpOwnLocks
        have (*zap.Logger)
        want (context.Context, *zap.Logger)

[mholt]

Not yet, I will probably be doing that soon (today or early next week)

[mholt]

@pteich Alright, I went ahead and updated CertMagic in Caddy and it should compile for you now: caddyserver/caddy@d06d0e7

[pteich]

Works like a charm now! Thanks @mholt