-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new release 1.5.2 #215
Comments
Hi Diederick, Yes, I will emit a new release in the next weeks. I will try to update ImGui in the process. In the mean time,you can download wheels in the actions on github: https://github.com/pthom/imgui_bundle/actions/workflows/wheels.yml
I am limited by the project size limit on Pypi (10GB max). I did hit the size limit a few months ago (after which I had to remove several older releases). In the meantime, I know that I can only release about 2 or 3 more versions before I hit the limit again. So I have to reduce the frequency |
Oof, i once had a request with them (for a name, not size), it took the better part of a year. Hope yours goes faster! It specifically the 1.90.7 support for shortcuts that would be interesting to try out, so that wouldn't be in your wheels yet. I saw also that there is a breaking change in docking/viewports, by the way, hope that doesn't break your stuff |
See also my new posts in issue #80, in case you don't get notified because its closed (I can't reopen) |
Hi Diederick, I did update ImGui to v1.90.7. It took me about half a day because I had to update also ImGui Test Engine, and also update the generator options due to new functions being overloaded. Concerning your other question, see 905a805 where I tentatively set the deployment target to 10.14. Please do test this with your user and keep me informed about the result, I cannot test that on my side; and I can only look at the CI results. |
Thanks for considering dropping the requirement to 10.14. I see the CI fails with the luckily informative message that Thanks for the trouble! |
I change it to 1015. |
Thanks! That built successfully. I have asked my student to try and install the wheel generated by your action. |
The cp311 wheel installed successfully on the student's platform, but when they try to run
I'm trying with 10.16 on my own fork now, will keep you updated. |
This brotli decoder may not be about the deployment target (may..), also doesn't work on 10.16, same error message. I thought maybe the user doesn't have this brotli available. I am now trying to use the macos-13 instead of macos-latest runner, lets see... |
Note (also for myself), |
Trying to build on an earlier runner fails:
So i guess that means were stuck unless one would build all these libraries yourself. The cibuildwheel docs say: This error may happen when you install a library using a package manager like Homebrew, which compiles the library for the macOS version of the build machine. This is not suitable for wheels, as the library will only work on the same macOS version as the build machine. You should compile the library yourself, or use a precompiled binary that matches the target macOS version. |
The strange thing perhaps is that the user is on 13.4, but the compatible targets declared by python go no higher than 10.16. |
Ok, this seems to be a bug in pip/packaging. See for instance here: I have asked my user to check. |
AFAIK, OS updates are free on Mac. Is there a compelling reason why those students cannot update their version of macOS? |
I hear from MacOS users that upgrades are likely to bring new problems and compatibility issues as much as new features. So they ten to upgrade once a year, if even that (don't change a working setup). But yeah, users shouldn't need to be forced to update MacOS to be able to install imgui_bundle. If this turns out to be running into a pip/packaging bug, then I guess the solution is a small addition to the docs. Will let you know/send pull request. |
Reading pip changelogs, i see that the fixed version of the packaging package still isn't vendored by latest pip, so that did nothing. But asking the user to run Thanks for going down this road with me! |
You're welcome. I just merged you PR. Thanks a lot |
Most welcome, glad we figured this out! |
Hi @pthom:
Cheers, |
Hello Dee, I'm trying to release this version, and I will have to change it to 1.5.1 (because of a failed previous attempt, pypi wont let me re-release this version) But I have to fight on several fronts, And I'm fighting since about a good 12 hours:
No, the support for Python 3.10 is still Ok, I do not produce binary wheels for it although, for reason of space in pypi. Maintaining so many versions by OS / OS version / Architecture / Python version has become very difficult and too much time consuming. |
So you mean 3.11 is the minimum required version? Ok, then i update. I understand the problem of having so many versions. Annoying about the macos versioning! I hope you can solve it and can make both builds so it doesn't become too restrictive. |
Hi Dee, Thanks for reporting the full screen issue. It is solved. I also just updated imgui to v1.90.9. this will be in the release. Did you see other issues? |
Hi Pascal, No, i didn't see other issues, but am only able to test my relatively simple application from location. If there would be something, I'm sure its super minor, and possibly due to me doing something hacky. But i'll report. Cool you're staying so up to date :) Hope you managed to slay the release dragons. |
Say, your wheels CI actions still builds for 3.10, the pip one does not. Is that intended? As said, I (and probably more users) would be happy to have a 3.10 package available too). |
I reenabled python 3.10 in the pip CI. I had disabled because it was failing on linux GitHub Runners for a while. GitHub sometimes pushes instable update to their runners. |
Ah, glad this started working again! |
After a bit of pondering, I'll leave this issue open for a while. |
Already using it (on Windows), seems to be working well :) |
Hi Pascal,
I see you are preparing a new release. Would it be possible for you to update to the latest imgui release before doing so, since there is new useful API for shortcuts there? Or are you able to make more frequent releases again?
Just for discussion!
As always, thanks a lot for this great tool, i really enjoy using it :)
The text was updated successfully, but these errors were encountered: