Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap sqlite3_exec for libsqlite3 #1674

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Wrap sqlite3_exec for libsqlite3 #1674

merged 1 commit into from
Jul 13, 2024

Conversation

Coekjan
Copy link
Contributor

@Coekjan Coekjan commented Jul 12, 2024

No description provided.

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 12, 2024

still no wrapping for the callback???

@Coekjan Coekjan marked this pull request as draft July 12, 2024 15:16
@Coekjan
Copy link
Contributor Author

Coekjan commented Jul 12, 2024

still no wrapping for the callback???

Sorry for disturbing. This is still in progress.

@Coekjan
Copy link
Contributor Author

Coekjan commented Jul 13, 2024

I imitated the callback function processing methods in other wrapped libraries.

Please review my changes. If I am wrong, kindly let me know.

@Coekjan Coekjan marked this pull request as ready for review July 13, 2024 08:29
@ksco
Copy link
Collaborator

ksco commented Jul 13, 2024 •
edited
Loading

IIRC wpp (wps presentation) uses this function, can you verify if that application works with wrapped libsqlite3 now? btw PR itself looks good to me.

@Coekjan
Copy link
Contributor Author

Coekjan commented Jul 13, 2024

IIRC wpp (wps presentation) uses this function, can you verify if that application works with wrapped libsqlite3 now? btw PR itself looks good to me.

Seems that WPP works good.

ptitSeb
ptitSeb requested changes Jul 13, 2024
View reviewed changes
@Coekjan Coekjan requested a review from ptitSeb July 13, 2024 10:31
@ptitSeb ptitSeb merged commit 7a4a442 into ptitSeb:main Jul 13, 2024
47 checks passed
@Coekjan Coekjan deleted the sqlite3-exec branch July 13, 2024 11:15
Javier97sm pushed a commit to Javier97sm/box64 that referenced this pull request Aug 16, 2024
@Coekjan @Javier97sm
Wrap sqlite3_exec for libsqlite3 (ptitSeb#1674)
30f658f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@ksco ksco ksco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coekjan @ptitSeb @ksco