Wrapped libtiff5 and libltdl7 #1677
Conversation
|
Still in Progress |
|
Done |
|
Looking good while rendering the PDF version of box86.com
|
|
On what architecture is that screenshot? Arm? RV64 or LA64 (or something else)? |
on rv64
|
| GO(TIFFInitZSTD, iFpi) | ||
| GO(TIFFInitWebP, iFpi) | ||
| // GO(TIFFCIELabToXYZ, vFpuiippp) | ||
| GO(TIFFXYZToRGB, iFpppp) |
There was a problem hiding this comment.
void TIFFXYZToRGB(TIFFCIELabToRGB *cielab, float X, float Y, float Z, uint32_t *R, uint32_t *G, uint32_t *B)
I’m on my phone, so I randomly picked a function to check, and it seems badly wrong?
There was a problem hiding this comment.
Ok, I concur, this function has a bad signature.
@kaixindeken how are you making the function signatures? Should I revert all your PR?
There was a problem hiding this comment.
(man page from here: https://www.manpagez.com/man/3/TIFFXYZToRGB/ )
There was a problem hiding this comment.
my apologis, i'll fix it right now. please do not revert this pr. i'll create a new pr to fix it all.
|
If you don’t understand how libwrapping works, feel free to talk to me first instead of submit something that is very wrong. |
* Wrapped libtiff5 * no types generated * libtiff5 added missing defs types undefs files * wrapped libltdl7 * rerun actions * add more wrapped function for tiff5 and ltdl7 * remove unused functions
wrapped libtiff5
wrapped libltdl7