[RV64_DYNAREC] Fixed some bugs for VMP #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is not happy. |
Fixed. |
ksco
reviewed
Jul 16, 2024
ksco
approved these changes
Jul 16, 2024
ksco
reviewed
Jul 16, 2024
| @@ -74,7 +74,7 @@ uintptr_t dynarec64_66(dynarec_rv64_t* dyn, uintptr_t addr, uintptr_t ip, int ni | |||
| nextop = F8; | |||
| GETGW(x1); | |||
| GETEW(x2, 0); | |||
| emit_add16(dyn, ninst, x1, x2, x3, x4, x6); | |||
| emit_add16(dyn, ninst, x1, x2, x5, x4, x6); | |||
There was a problem hiding this comment.
GWBACK is fine, but there is no harm in changing either...
This was referenced Jul 16, 2024
Javier97sm
pushed a commit
to Javier97sm/box64
that referenced
this pull request
Aug 16, 2024
* [RV64_DYNAREC] Fixed reg x3 conflict with the GETEW macro * [RV64_DYNAREC] Fixed (LOCK) XCHG Eb, Gb again * [RV64_DYNAREC] Fixed register conflict in (LOCK) XCHG Eb, Gb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.