Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RV64_DYNAREC] Fixed vector infra #1705

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[RV64_DYNAREC] Fixed vector infra #1705

merged 1 commit into from
Jul 22, 2024

Conversation

ksco
Copy link
Collaborator

@ksco ksco commented Jul 22, 2024

For vlen>128, we cannot use load/store whole vector instructions! Sorry for this mistake. This PR replaced all the whole vector load/stores with the normal ones, which requires the vtype to be set correctly using SET_ELEMENT_WIDTH().

@ksco
Copy link
Collaborator Author

ksco commented Jul 22, 2024

Related to this PR:

I think there are certain limitations in the current vector infrastructure -- mainly for opcodes that are essentially element-width-agnostic.

For example, MOVDQA can be implemented with vle8.v, vle16.v, vle32.v, and vle64.v, it will be good if we know the predecessor's element width in compile time to choose the best one.

Previously I implemented MOVDQA with "load whole vector", but that unfortunately only works on vlen=128.

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 22, 2024

Related to this PR:

I think there are certain limitations in the current vector infrastructure -- mainly for opcodes that are essentially element-width-agnostic.

For example, MOVDQA can be implemented with vle8.v, vle16.v, vle32.v, and vle64.v, it will be good if we know the predecessor's element width in compile time to choose the best one.

Previously I implemented MOVDQA with "load whole vector", but that unfortunately only works on vlen=128.

You can use a ecanism similar to float/i64/double of Float, but SSE handling is quite different, so an other mecanism should be used.

@ptitSeb ptitSeb merged commit 9c1b015 into ptitSeb:main Jul 22, 2024
47 checks passed
@ksco ksco deleted the fix-vector branch July 23, 2024 04:50
@ksco ksco restored the fix-vector branch July 23, 2024 04:50
@ksco ksco deleted the fix-vector branch July 23, 2024 04:50
Javier97sm pushed a commit to Javier97sm/box64 that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants