Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID] Not use 'libbsd.so' as needed lib and don't define NEEDED_LIBS_234 for Android Too, Use BOX64_LD_LIBRARY_PATH instead of LD_LIBRARY_PATH on CTEST #1754

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

KreitinnSoftware
Copy link
Contributor

No description provided.

@ptitSeb
Copy link
Owner

ptitSeb commented Aug 25, 2024

All Android / Termux tests seems to crash now, can you check?

@KreitinnSoftware
Copy link
Contributor Author

All Android / Termux tests seems to crash now, can you check?

It's because trying to preload libraries from x64lib folder I guess

@KreitinnSoftware
Copy link
Contributor Author

On my local machine just removing x64lib folder ctest works

@ptitSeb
Copy link
Owner

ptitSeb commented Aug 25, 2024

Not sure I understand what preload you are talking about. This breakage is new to this PR...

@ptitSeb
Copy link
Owner

ptitSeb commented Aug 25, 2024

And it seems it's segfaulting, so I doubt it's a preload of 64bits libs on a 32bits run (the libs should be just ignored there)

@KreitinnSoftware
Copy link
Contributor Author

Not sure I understand what preload you are talking about. This breakage is new to this PR...

CMake gives error,

/usr/bin/cmake: /home/pablo/box64/b/../x64lib/libstdc++.so.6: version `CXXABI_1.3.15' not found (required by /usr/bin/cmake)
/usr/bin/cmake: /home/pablo/box64/b/../x64lib/libstdc++.so.6: version `CXXABI_1.3.15' not found (required by /usr/lib/libcppdap.so)

@KreitinnSoftware
Copy link
Contributor Author

This is quite strange, it shouldn't happen

@ptitSeb
Copy link
Owner

ptitSeb commented Aug 25, 2024

Ah, ok. interferances with the actual cmake binary. I see.

Yeah, better use BOX64 versions of ld_lib_path...

@KreitinnSoftware
Copy link
Contributor Author

Without libpthread.so functions, test06 simply crashes, then will enable libpthread as required lib again, libbsd is not needed I guess

@KreitinnSoftware KreitinnSoftware changed the title [ANDROID] Not use 'libbsd.so', 'libpthread.so' as needed libs and don't define NEEDED_LIBS_234 for Android Too [ANDROID] Not use 'libbsd.so' as needed lib and don't define NEEDED_LIBS_234 for Android Too, Use BOX64_LD_LIBRARY_PATH instead of LD_LIBRARY_PATH on CTEST Aug 25, 2024
@ptitSeb ptitSeb merged commit a7c61d8 into ptitSeb:main Aug 25, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants