Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID][BOX32] Fix __libc_init, Fix Some Warnings #1887

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

KreitinnSoftware
Copy link
Contributor

No description provided.



void fillALProcWrapper()
void fillALProcWrapper(box64context_t* context)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the signature of this function. Use my_context if you nedd the context (but for what?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because of the compiler warning, so it compiled without the warning, I didn't know it was intentional to leave it as it was

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/pablo/box64/src/wrapped/wrappedopenal.c:116:39: warning: too many arguments in call to 'fillALProcWrapper'
fillALProcWrapper(emu->context);
~~~~~~~~~~~~~~~~~ ^
/home/pablo/box64/src/wrapped/wrappedopenal.c:116:26: warning: passing arguments to 'fillALProcWrapper' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
fillALProcWrapper(emu->context);
^
2 warnings generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'll just return to how it was then

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be fixed at the warning, removog the parameter in call, that's the mystake

@@ -149,7 +147,7 @@ EXPORT void* my_alcGetProcAddress(x64emu_t* emu, void* device, void* name)
const char* rname = (const char*)name;
printf_log(LOG_DEBUG, "Calling alcGetProcAddress(%p, %s)\n", device, rname);
if(!emu->context->alwrappers) // could be moved in "my" structure...
fillALProcWrapper();
fillALProcWrapper(NULL);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for NULL here now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already removed on latest commit

@ptitSeb ptitSeb merged commit a6baf1f into ptitSeb:main Sep 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants