Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LA64_DYNAREC] Add adc8, adc8c, adc16 and testadc #2069

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

xiangzhai
Copy link
Contributor

Hi,

Testcase testadc Passed on la64_lbt supported platform:

Dynarec for LoongArch with extension LSX LASX LBT_X86 PageSize:16384 Running on Loongson-3A5000-HV with 4 Cores
Will use time-based emulation for rdtsc, even if hardware counter are available
Will use Software counter measured at 1.0 GHz emulating 2.0 GHz
Params database has 14 entries
Box64 with Dynarec v0.3.1  built on Nov 25 2024 11:44:37
BOX64: Didn't detect 48bits of address space, considering it's 39bits
Counted 59 Env var
BOX64 LIB PATH: BOX64 BIN PATH: ./:bin/:/home/zhaixiang/.cargo/bin/:/usr/local/bin/:/usr/bin/:/bin/:/usr/local/games/:/usr/games/:/home/zhaixiang/rust-1.77.0-loongarch64-unknown-linux-gnu/cargo/bin/:/home/zhaixiang/rust-1.77.0-loongarch64-unknown-linux-gnu/rustc/bin/
Looking for /home/zhaixiang/testadc
Rename process to "testadc" 
Using native(wrapped) libc.so.6
Using native(wrapped) ld-linux-x86-64.so.2
Using native(wrapped) libpthread.so.0
Using native(wrapped) libdl.so.2
Using native(wrapped) libutil.so.1
Using native(wrapped) librt.so.1
Using native(wrapped) libbsd.so.0
al=0xfe
dl=0x1
ax=0xfffe
dx=0x1
eax=0xfffffffe
edx=0x1

Also passed when disabled la64_lbt:

export BOX64_DYNAREC_LA64NOEXT=1

Dynarec for LoongArch  PageSize:16384 Running on Loongson-3A5000-HV with 4 Cores
Will use time-based emulation for rdtsc, even if hardware counter are available
Will use Software counter measured at 1.0 GHz emulating 2.0 GHz
Params database has 14 entries
Box64 with Dynarec v0.3.1  built on Nov 25 2024 11:44:37
BOX64: Didn't detect 48bits of address space, considering it's 39bits
Counted 59 Env var
BOX64 LIB PATH: BOX64 BIN PATH: ./:bin/:/home/zhaixiang/.cargo/bin/:/usr/local/bin/:/usr/bin/:/bin/:/usr/local/games/:/usr/games/:/home/zhaixiang/rust-1.77.0-loongarch64-unknown-linux-gnu/cargo/bin/:/home/zhaixiang/rust-1.77.0-loongarch64-unknown-linux-gnu/rustc/bin/
Looking for /home/zhaixiang/testadc
Rename process to "testadc" 
Using native(wrapped) libc.so.6
Using native(wrapped) ld-linux-x86-64.so.2
Using native(wrapped) libpthread.so.0
Using native(wrapped) libdl.so.2
Using native(wrapped) libutil.so.1
Using native(wrapped) librt.so.1
Using native(wrapped) libbsd.so.0
al=0xfe
dl=0x1
ax=0xfffe
dx=0x1
eax=0xfffffffe
edx=0x1

Please review my patch.

Thanks,
Leslie Zhai

Copy link
Collaborator

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, please format your code using clang-format with the .clang-format file we have in the repo. I would like all the LA64 DynaRec code to be formatted.

@xiangzhai xiangzhai requested a review from ksco November 25, 2024 06:38
@ksco ksco requested a review from ptitSeb November 25, 2024 06:53
@ptitSeb ptitSeb merged commit c30a392 into ptitSeb:main Nov 25, 2024
27 checks passed
GETGD;
SMDMB();
if (MODREG) {
ed = xRAX + (nextop & 7) + (rex.b << 3);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong too.

xiangzhai added a commit to xiangzhai/box64 that referenced this pull request Nov 26, 2024
@xiangzhai xiangzhai deleted the la64_dynarec_adc branch December 12, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants