Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lens placeholder images not loading #103

Closed
dingerr opened this issue Feb 6, 2024 · 6 comments
Closed

lens placeholder images not loading #103

dingerr opened this issue Feb 6, 2024 · 6 comments
Assignees
Labels
server Server isn't working

Comments

@dingerr
Copy link
Sponsor

dingerr commented Feb 6, 2024

Please make sure the Wiki and Discussions section does not solve your problem:

If you are having technical difficulties please provide the following information:
System (please complete the following information):

  • OS: [e.g. Windows, Mac OS] Windows 11
  • Server Version: [e.g. 2.0.6, , 3.0.0, 3.0.1, ...] 3.2.0
  • Snap Camera Version: [e.g. 1.19, 1.20, 1.21] 1.21
  • Signature Patch applied: [yes or no] yes

Hi, a lot of my lenses placeholder pictures are not loading. I will attach an image of what it shoes for the placeholder image.
I love your work and appreciate all that you have done for snapcam etc.
Hope to hear back from you soon, thanks again!
df3459b88c6b731918e76b2c38d6c903

@dingerr dingerr added the other Something other isn't working label Feb 6, 2024
@ptrumpis
Copy link
Owner

ptrumpis commented Feb 6, 2024

There was another undocumented change in version 3.2.0.
I forgot to add it to the changelog (I'll update the changelog).

Some Snap lenses do not have a preview image at all and some lenses do not load the image due to a network error.
Before v3.2.0 it was not possible to visually distinguish these two cases.

In v3.2.0, Snap lenses with their thumbnails missing will be shown with the default images provided by the server.
These images are located in the server directory under "/nginx/snap-camera-media".
see here

The images are not particularly beautiful by default, but they clearly stand out.
You are welcome to edit them in your directory.

It would be nice if you could give me 2-3 share links to snap lenses that have the problem.
Then I can check whether these lenses really do not contain their own thumbnail or whether there is a bug.

@ptrumpis
Copy link
Owner

ptrumpis commented Feb 9, 2024

Thank you, I'll provide a fix shortly

@dingerr
Copy link
Sponsor Author

dingerr commented Feb 9, 2024

awesome! thanks for the quick response, I really appreciate all you do, and me and my friends use snapcam daily.
:)
also please let me know if you ever need any help with testing / beta updates or whatever, I'd be honored to help.

@dingerr
Copy link
Sponsor Author

dingerr commented Feb 13, 2024

@ptrumpis
Any luck with finding the root of the issue or a workaround? I am still having / it is showing no placeholder image for almost the majority of my filters.
Again much appreciated.

@ptrumpis
Copy link
Owner

Resolved with Patch Release v3.2.1

@ptrumpis ptrumpis added server Server isn't working and removed other Something other isn't working labels Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Server isn't working
Projects
None yet
Development

No branches or pull requests

2 participants