fix(VsModal): move esc eventListener from composable to store #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithoo
commented
Oct 7, 2024
| push(id: string) { | ||
| this.idStack.push(id); | ||
| constructor() { | ||
| document.addEventListener('keydown', (event: KeyboardEvent) => { |
There was a problem hiding this comment.
딱 한 군데서만 event를 등록해야 하는데 그 지점이 store 밖에 잡히는 곳이 없어서 일단 여기에 작성했습니다ㅠ
Vlossom bootstrap 시점에 라이프사이클 함수를 파야할지 고민되는 지점입니다;;;
일단 버그 수정 위해서 여기 작성하고 설계를 고민해보는게 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (check all applicable)
Summary
esc eventListener 중복 등록 이슈 버그 수정
Description