feat!: update ed25519-dalek to latest prerelease #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
|
Hey @dignifiedquire I looked over n0-computer/iroh#3476 again. How sure are you the dependency upgrades are really a breaking change? Isn't this just a version conflict in iroh? You are specifying ed25519-dalek in iroh-base and setting it to Please correct me if I am missing something. |
Contributor
Author
|
The reason why this is a breaking change for the |
SeverinAlexB
approved these changes
Sep 30, 2025
Contributor
Author
|
any chance I could get a release for this? |
Merged
Contributor
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Oct 6, 2025
## Description - Upgrade to rand@0.9 - Upgrade dalek crates to prereleases Blocked on - [x] RustCrypto/nacl-compat#182 - [x] pubky/mainline#71 - [x] pubky/pkarr#186 Closes #3198 ## Breaking Changes - interfaces that depend on `rand` now need `0.9` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change, because this is reexported as part of the public interface