Add ibc3 feature #37
Closed
Add ibc3 feature #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pretty much every chain is now running ibc v3 and v4 coming with the new wasmd upgrade so I guess this is fine. |
0xekez
reviewed
Nov 21, 2022
| @@ -31,10 +31,13 @@ pub enum ExecuteMsg { | |||
| } | |||
|
|
|||
| #[cw_serde] | |||
| #[derive(QueryResponses)] | |||
0xekez
approved these changes
Nov 21, 2022
|
i've moved this commit into my latest changes: 1b086c6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what i know, ibc3 is the norm in cosmos, including this feature seems to be the logic thing to do in ics721.
Small fixes to unit-tests,
ibc_channel_openchange of expected result, and upgrade optimizer version to 0.12.9Closes #36