Added handling class data and token data #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xekez
reviewed
Dec 30, 2022
Co-authored-by: ekez <30676292+0xekez@users.noreply.github.com>
0xekez
reviewed
Jan 1, 2023
There was a problem hiding this comment.
looking good! would you mind adding some tests for these?
i think the big things that need to be covered are:
- does the validation logic for
NonFungibleTokenPacketDatawork (unit tests + 1 integration test). - does the memo get added to response attributes (unit test or heavily mocked integration test b/c multi-test can't do IBC stuff)
- does class data get forwarded? this should be testable using the adversarial tests framework by crafting a packet on the adversary chain with data and then sending it across the other two and making sure that the data is queryable.
Co-authored-by: ekez <30676292+0xekez@users.noreply.github.com>
0xekez
reviewed
Jan 2, 2023
0xekez
reviewed
Jan 2, 2023
0xekez
reviewed
Jan 3, 2023
0xekez
reviewed
Jan 3, 2023
|
merging this. i will write more tests on top. thanks @Art3miX! you have significantly increased the speed at which we'll be able to ship this. |
0xekez
added a commit
that referenced
this pull request
Jan 3, 2023
* Added handling class data nad token data * fmt/clippy * Apply suggestions from code review Co-authored-by: ekez <30676292+0xekez@users.noreply.github.com> * zeke review changes * added memo * Update contracts/cw-ics721-bridge/src/contract.rs Co-authored-by: ekez <30676292+0xekez@users.noreply.github.com> * zeke comments fixes * moved tests to testing folder * Add test for metadata forwarding. Co-authored-by: ekez <30676292+0xekez@users.noreply.github.com> Co-authored-by: ekez <zekemedley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.