Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rustc to fix the wasm-build #48

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Upgrade rustc to fix the wasm-build #48

merged 3 commits into from
Jan 28, 2022

Conversation

axvn
Copy link
Contributor

@axvn axvn commented Jan 28, 2022

The wasm-build step failed due to rkyv package failed to build on old version rustc.

@axvn axvn mentioned this pull request Jan 28, 2022
Merged
@the-frey the-frey mentioned this pull request Jan 28, 2022
Merged
@the-frey the-frey requested review from the-frey and orkunkl January 28, 2022 11:38
the-frey
the-frey previously approved these changes Jan 28, 2022
View reviewed changes
@the-frey
Copy link
Collaborator

LGTM. @orkunkl are you happy to get this merged?

@the-frey the-frey mentioned this pull request Jan 28, 2022
Closed
@orkunkl
Copy link
Contributor

orkunkl commented Jan 28, 2022

Better to stick to 1.55

@axvn
Copy link
Contributor Author

axvn commented Jan 28, 2022

@orkunkl what's the consideration? 1.56 is stable as well.

@orkunkl
Copy link
Contributor

orkunkl commented Jan 28, 2022

@orkunkl what's the consideration? 1.56 is stable as well.
latest rust-optimizer uses 1.55 https://github.com/CosmWasm/rust-optimizer/blob/fa088e7c4d46316a41fadc9cbd2daf95956df5a9/CHANGELOG.md#0123
Best to keep it same everywhere

@axvn
Copy link
Contributor Author

axvn commented Jan 28, 2022

@orkunkl Makes sense, thanks for explanation, changed to 1.55.0

@axvn axvn requested a review from the-frey January 28, 2022 15:04
@the-frey the-frey merged commit dab3e6c into public-awesome:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-frey the-frey the-frey approved these changes

@orkunkl orkunkl orkunkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axvn @the-frey @orkunkl