respond shane comments part 1

public-awesome · Aug 16, 2023 · d8e6ab8 · d8e6ab8
1 parent c9df481
commit d8e6ab8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/contracts/factories/base-factory/Cargo.toml b/contracts/factories/base-factory/Cargo.toml
@@ -35,7 +35,7 @@ schemars        = { workspace = true }
 serde           = { workspace = true }
 sg1             = { workspace = true }
 sg2             = { workspace = true }
-cw721-base = { workspace = true }
-sg721-base      = { workspace = true} 
+cw721-base = { workspace = true, features = ["library"] }
+sg721-base      = { workspace = true, features = ["library"]} 
 sg-std          = { workspace = true }
 thiserror       = { workspace = true }
diff --git a/contracts/factories/vending-factory/src/contract.rs b/contracts/factories/vending-factory/src/contract.rs
@@ -82,7 +82,6 @@ pub fn execute_create_minter(
             got: msg.init_msg.per_address_limit,
         });
     }
-    //TODO BURNMINT
     let denom_min_mint_price = params.min_mint_price.clone().denom()?;
     ensure!(
         denom_min_mint_price == msg.init_msg.mint_price.denom,

diff --git a/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs b/test-suite/src/common_setup/setup_minter/open_edition_minter/mock_params.rs
@@ -61,15 +61,6 @@ pub fn mock_create_minter_init_msg(
     }
 }
 
-//     start_minter_time: Option<Timestamp>,
-//     end_minter_time: Option<Timestamp>,
-//     nft_data: Option<NftData>,
-//     max_per_address_limit: Option<u32>,
-//     per_address_limit_minter: Option<u32>,
-//     mint_price_minter: Option<Coin>,
-//     sg721_code: Option<Box<dyn Contract<StargazeMsgWrapper>>>,
-//     sg721_codeid: Option<u64>,
-
 pub fn mock_params_proper() -> OpenEditionMinterParams {
     OpenEditionMinterParams {
         code_id: 1,